Add new v6 buttons to the adaptive stylesheet #4371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controlbar elements .vjs-subs-caps-button and .vjs-volume-panel are new in v6, but had not been added to this CSS file.
|
the volume-control is still available. The volume-menu-button was just swapped out for the volume-panel. Should we have all in there then? |
gkatsev
reviewed
Jun 26, 2017
| @@ -7,9 +7,9 @@ | |||
|
|
|||
| .vjs-current-time, .vjs-time-divider, .vjs-duration, .vjs-remaining-time, | |||
| .vjs-playback-rate, .vjs-progress-control, | |||
| .vjs-mute-control, .vjs-volume-control, | |||
There was a problem hiding this comment.
we probably still want to keep vjs-volume-control in here and add vjs-volume-panel since it's possible to add the volume control to the control bar separately as well.
| @@ -34,7 +34,7 @@ | |||
| .video-js.vjs-layout-small:not(.vjs-fullscreen) { | |||
| .vjs-current-time, .vjs-time-divider, .vjs-duration, .vjs-remaining-time, | |||
| .vjs-playback-rate, | |||
| .vjs-mute-control, .vjs-volume-control, | |||
| .vjs-mute-control, .vjs-volume-panel, | |||
There was a problem hiding this comment.
according to the comment above, vjs-volume-panel shouldn't be here because it's a replacement for the volume menu button.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
gkatsev
added
pinned
6 tasks
gkatsev
pushed a commit
that referenced
this pull request
Oct 10, 2018
…yer width. (#5471) This adds a breakpoints option. By default, this option is false meaning this is an opt-in feature. When passing true, it will use a default set of breakpoints. Or custom breakpoints can be passed if users do not like our breakpoints (or previously-existing style decisions). - Add breakpoints option. - Adds some new (currently unused) classes: vjs-layout-medium, vjs-layout-large, vjs-layout-x-large, and vjs-layout-huge. - Add updateCurrentBreakpoint and currentBreakpoint methods to the player. - Update css/components/_adaptive.scss - Add sandbox/responsive.html.example Closes #4371
gkatsev
pushed a commit
that referenced
this pull request
Oct 31, 2018
…yer width. (#5471) This adds a breakpoints option. By default, this option is false meaning this is an opt-in feature. When passing true, it will use a default set of breakpoints. Or custom breakpoints can be passed if users do not like our breakpoints (or previously-existing style decisions). - Add breakpoints option. - Adds some new (currently unused) classes: vjs-layout-medium, vjs-layout-large, vjs-layout-x-large, and vjs-layout-huge. - Add updateCurrentBreakpoint and currentBreakpoint methods to the player. - Update css/components/_adaptive.scss - Add sandbox/responsive.html.example Closes #4371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controlbar elements .vjs-subs-caps-button and .vjs-volume-panel
are new in v6, but had not been added to this CSS file.
Description
Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist