Remove playbackRate blacklist for recent Android Chrome #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
May 8, 2017
src/js/utils/browser.js
Outdated
| const match = USER_AGENT.match(/Chrome\/(\d+)/); | ||
|
|
||
| if (match && match[1]) { | ||
| return match[1]; |
There was a problem hiding this comment.
we should return parseFloat(match[1]) here so that we can actually do number comparison. The tests would need to be updated in that case.
gkatsev
approved these changes
May 8, 2017
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android Chrome now supports playbackRate properly, so removes the blacklist added in #3246 for newer Chrome versions.
Specific Changes proposed
Adds
browser.CHROME_VERSIONas a necessary evil.No longer blacklists for Chrome 58+ -- this could possibly be fixed since 52, but 58 is all I've been able to test on and most users should keep Chrome up to date.
Requirements Checklist