Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replaced VolumeMenuButton with VolumePanel in component tree doc #4267

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

alex-barstow
Copy link
Contributor

Description

Closes #4266

Video.js 6 replaces the VolumeMenuButton component with the VolumePanel component. This PR updates the default component tree in the video.js 6 docs (https://github.com/videojs/video.js/blob/master/docs/guides/components.md#default-component-tree) to reflect this.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev gkatsev merged commit 02721c7 into videojs:master Apr 7, 2017
@gkatsev
Copy link
Member

gkatsev commented Apr 7, 2017

Thanks @alex-barstow!

@alex-barstow alex-barstow deleted the update-components-md branch April 7, 2017 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Component Tree doc doesn't contain VolumePanel component
3 participants