Minimum volume after unmuting #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! there seems to be a conflict in the test file, can you take a look at that? |
|
@gkatsev Oops! Got it, thanks. |
gkatsev
approved these changes
Mar 24, 2017
brandonocasey
approved these changes
Mar 24, 2017
|
Thanks @kevinlitchfield! |
|
Looks like IE9 rounding strikes again! |
Merged
gkatsev
pushed a commit
that referenced
this pull request
Mar 24, 2017
#4227 caused an error in IE9 because it returns back a bad float number. Instead, we toFixed(1) the response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unmuting and
lastVolumeis less than 0.1, set volume to 0.1 instead of tolastVolume.Fixes #4054.
Before
Volume set to 0.024390243902439025.
After
Volume set to 0.1.