update videojs-vtt.js to 0.12.3 #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Mar 23, 2017
src/js/tech/tech.js
Outdated
| @@ -551,7 +551,7 @@ class Tech extends Component { | |||
| // passed in | |||
| const script = document.createElement('script'); | |||
|
|
|||
| script.src = this.options_['vtt.js'] || 'https://cdn.rawgit.com/gkatsev/vtt.js/vjs-v0.12.1/dist/vtt.min.js'; | |||
| script.src = this.options_['vtt.js'] || 'https://cdn.rawgit.com/gkatsev/vtt.js/vjs-v0.12.3/dist/vtt.min.js'; | |||
There was a problem hiding this comment.
this file doesn't exist anymore since it isn't check in to github.
There was a problem hiding this comment.
What should this be updated to so the right file is loaded if options isn't passed in?
There was a problem hiding this comment.
Looking into getting it published to the CDN.
Also, I realized that we probably want to update vttjs to get rid of browser.js and only use browser-index.js.
mjneil
force-pushed
the
update/vtt.js-0.12.3
branch
from
504b1bf to
6d3960e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.