Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont pause when the ErrorDisplay is opened #4187

Merged
merged 1 commit into from
Mar 13, 2017
Merged

fix: dont pause when the ErrorDisplay is opened #4187

merged 1 commit into from
Mar 13, 2017

Conversation

brandonocasey
Copy link
Contributor

Description

  • Added a feature to make it optional for ModalDialog to pauseOnOpen
  • Use pauseOnOpen: false in ErrorDisplay so that errors that can recover during playback will recover

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@brandonocasey brandonocasey merged commit 4ec3b56 into 5.x Mar 13, 2017
@gkatsev gkatsev deleted the fix/5.x-dont-pause-error-display branch March 24, 2017 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @gkatsev