Fix poster image to match the video in the 'combined-tracks.html' example in sandbox #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracks.html' example in sandbox
gkatsev
requested changes
Mar 5, 2017
sandbox/combined-tracks.html.example
Outdated
| @@ -25,7 +25,7 @@ | |||
| <pre>open http://localhost:9999/sandbox/index.html</pre> | |||
| </div> | |||
|
|
|||
| <video id="vid1" class="video-js vjs-default-skin" lang="en" controls preload="auto" width="640" height="264" poster="http://vjs.zencdn.net/v/oceans.png"> | |||
| <video id="vid1" class="video-js vjs-default-skin" lang="en" controls preload="auto" width="640" height="264"> | |||
There was a problem hiding this comment.
what about swapping to //d2zihajmogu5jn.cloudfront.net/elephantsdream/poster.png?
There was a problem hiding this comment.
Oh, I didn't know that the poster for ED was on the CDN. I can make that change - thanks @gkatsev!
gkatsev
approved these changes
Mar 6, 2017
OwenEdwards
changed the title
OwenEdwards
deleted the
chore/remove-incorrect-poster-from-sandbox-example
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove poster image which doesn't match the video from the 'combined-tracks.html' example in sandbox, and also fixed a typo.
Requirements Checklist