fix(MenuButton) Unify behavior of showing/hiding #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a `hideThreshold` property that defaults to 1 so descendants can override it if necessary. Right now the only descendant that will override will be `CaptionsButton` because video.js adds a "captions settings" for emulated text tracks.
|
Thanks @justinanastos. Can you update the subs-caps-button as well? It was just added and should work similar to the captions-button. |
|
@gkatsev I'm sorry, I totally forgot to update the |
|
Wew, I've attained |
|
@justinanastos no worries. I have a PR coming up that rectifies it. |
|
Here's my update #4171. |
gkatsev
added a commit
that referenced
this pull request
Mar 7, 2017
This is a followup from #4157 but for the subs-caps button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3993 but targeting
master.