fix: cues at startTime 0 do not fire #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Wait for tech to be ready before watching for `timeupdate` * update unit tests to use TechFaker * Add a unit test to verify that we wait for Tech to be ready.
brandonocasey
commented
Mar 2, 2017
| @@ -339,14 +344,17 @@ class TextTrack extends Track { | |||
| addCue(originalCue) { | |||
| let cue = originalCue; | |||
|
|
|||
| if (!(originalCue instanceof window.vttjs.VTTCue)) { | |||
| if (window.vttjs && !(originalCue instanceof window.vttjs.VTTCue)) { | |||
| cue = new window.vttjs.VTTCue(originalCue.startTime, originalCue.endTime, originalCue.text); | |||
|
|
|||
| for (const prop in originalCue) { | |||
| if (!(prop in cue)) { | |||
There was a problem hiding this comment.
should we just do || prop === id instead of copying it below? Doesn't really matter all that much I guess though.
There was a problem hiding this comment.
I think since we're only copying the id, having it be separate with a comment makes it much nicer and explicit. Though, if we end up needing to force copy other stuff, I'd agree combining into here would make more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously
timeupdatewould fire before the video was playing, and the tech was not ready. This caused issues whenpreloadwas set toauto, becausecuechangewould fire before the video was even started for cues with astartTimeof 0.timeupdateSpecific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist