fix: copy basic plugin properties onto the wrapper

[brandonocasey]

Description

Copy basic plugin properties to prevent breaking older basic plugins

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Unit Tests updated or fixed
• Reviewed by Two Core Contributors

[misteroneill]

I feel like this belongs in the createBasicPlugin function.

[brandonocasey]

I thought that too at first, but Player.prototype[name] does not exist until we get the return value from createBasicPlugin

[brandonocasey]

If we really want it in createBasicPlugin, then we have to do the Player.prototype[name] assign in there as well. I don't see any problems with that. Thoughts?

[gkatsev]

couldn't it just copy the props from plugin onto the instance that createBasicPlugin returns`?

[brandonocasey]

basic plugins don't have to return an instance though

[gkatsev]

createBasicPlugin is a function that returns a function. It's a bit confusing.
But instance is inside the returned function, you'd want to do the property copying in the outer arrow function instead.

[gkatsev]

I almost thought just now that createBasicPlugin initialized basic plugins when called, but it doesn't do that.

[brandonocasey]

yeah calling the function that createBasicPlugin returns on player is actually what initializes. The question is do we want to copy the methods that are on the plugin right away (this is how it used to work in 5.x)? or only after the plugin has been initialized.

Examples:

After initialization copy properties

var basic = () => {};
basic.VERSION = '9.9.9';
videojs.registerPlugin('basic', basic);
var player = videojs('some-id');

console.log(player.basic.VERSION);
// undefined

player.basic();
console.log(player.basic.VERSION);
// 9.9.9

Before initialization copy properties

var basic = () => {};
basic.VERSION = '9.9.9';
videojs.registerPlugin('basic', basic);
var player = videojs('some-id');

console.log(player.basic.VERSION);
// '9.9.9'

[gkatsev]

I think we want to mimic current behavior, which means that we want to copy it before init and the plugin would need to handle things after init, like they do now.

[gkatsev]

Tests are fine except that IE8 is being weird on browserstack.