Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch from ghooks to husky #4074

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Conversation

typicode
Copy link
Contributor

Description

Fix #3930

husky will automatically migrate hooks installed by ghooks so there's no additional action.

Specific Changes proposed

  • Removes ghooks devDependency and configuration.
  • Adds husky devDependency and adds prepush script.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Feb 13, 2017

Thanks!
I assume that husky looks for the various scripts as npm scripts?

@typicode
Copy link
Contributor Author

Yes, exactly. It works more or less the same way as ghooks except hook scripts are located in scripts.

{
  "scripts": {
    "precommit": "npm test",
    "prepush": "npm test",
    "...": "..."
  }
}

@gkatsev
Copy link
Member

gkatsev commented Feb 13, 2017

Thanks @typicode.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brandonocasey brandonocasey merged commit c3b1d68 into videojs:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to husky from ghooks
4 participants