fix(sass): import path has cwd once again #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Feb 13, 2017
|
Can I ask you to make another PR but this time against the 5.x branch? I'll then be able to make a patch release of the 5.17. |
|
Sure. I can get that to you at some point tonight. |
tsi
added a commit
to tsi/video.js
that referenced
this pull request
Nov 20, 2019
Fixes videojs#4061 in `master` (7.x)
|
just created a PR to fix this in 7.x. please review #6326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #4055, node-sass v4.5.0 has reverted back to allowing
@import "node_modules/videojs-font/scss/icons";Specific Changes proposed
Reverting back to this format allows for referencing video.js as a dependency in other projects without build failures when importing the sass files from this package. It would be ideal to bring this back into v5.x as well as v6.x of video.js
Requirements Checklist