fix: localize aria-labels #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
commented
Feb 2, 2017
| @@ -26,7 +26,7 @@ class CaptionsButton extends TextTrackButton { | |||
| */ | |||
| constructor(player, options, ready) { | |||
| super(player, options, ready); | |||
| this.el_.setAttribute('aria-label', 'Captions Menu'); | |||
| this.el_.setAttribute('aria-label', this.localize('Captions Menu')); | |||
There was a problem hiding this comment.
@OwenEdwards thoughts on whether we need to create a new item for this or if we can just re-use Captions and Chapters etc for these button labels?
There was a problem hiding this comment.
Cool. I'll rebase this after that one gets merged then.
misteroneill
reviewed
Feb 6, 2017
lang/en.json
Outdated
| @@ -1,4 +1,6 @@ | |||
| { | |||
| "audio player": "audio player", | |||
| "video player": "video player", | |||
There was a problem hiding this comment.
Should these be title-cased for consistency as long as we're pushing toward a major release?
There was a problem hiding this comment.
I agree, these and others (e.g. "progress bar") ought to be title-cased.
gkatsev
force-pushed
the
aria-label-locaalization
branch
from
181c09f to
8d869b4
Compare
OwenEdwards
previously requested changes
Feb 8, 2017
| @@ -48,7 +48,7 @@ class SeekBar extends Slider { | |||
| return super.createEl('div', { | |||
| className: 'vjs-progress-holder' | |||
| }, { | |||
| 'aria-label': 'progress bar' | |||
| 'aria-label': this.localize('progress bar') | |||
There was a problem hiding this comment.
Doesn't this need to be in Title Case too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2728