Expand testing info in CONTRIBUTING.md
#4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlitchfield
changed the title
CONTRIBUTING.md
gkatsev
reviewed
Feb 2, 2017
CONTRIBUTING.md
Outdated
| ```sh | ||
| npm test | ||
| ``` | ||
| Tests can be run either from the shell (`npm test`) or from the browser(`npm start`; `http://localhost:9999/test`). See [Running tests](#running-tests) for more information. |
There was a problem hiding this comment.
I think in this section we should just mention npm test but linking to the other section and saying there's more info there is a great idea.
There was a problem hiding this comment.
@gkatsev Sounds good. Let me know if you have thoughts on the updated language.
gkatsev
approved these changes
Feb 2, 2017
brandonocasey
approved these changes
Feb 2, 2017
|
Thanks for the PR! I have no doubt that this will help contributors that don't work with the codebase often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few lines to
CONTRIBUTING.mdexplaining how to run tests from the browser.