Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable title attribute on menu items, fixes #3699 (same as #4009, but on master branch) #4019

Conversation

OwenEdwards
Copy link
Member

Description

Prevents a title attribute from being applied to MenuItems. Fixes #3699

Specific Changes proposed

MenuItem indicates to ClickableComponent that the control is not just an icon, so it shouldn't have a title attribute.

Requirements Checklist

  • Feature implemented
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Reviewed by Two Core Contributors

@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Feb 2, 2017
@gkatsev gkatsev merged commit 04f23c1 into videojs:master Feb 2, 2017
@OwenEdwards OwenEdwards deleted the fix/remove-title-attrib-on-menu-items-in-v6 branch February 2, 2017 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y This item might affect the accessibility of the player
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title attribute value in closed-caption menu is broken
2 participants