fix: allow changing volume in full height of volume control #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has a small issue where if you drag out of the volume control, it'll hide but I think that should be fixed after #3981 has been merged. I could either rebase this and update here or make a separate PR for the lock showing aspect then. |
|
I think the cursor ought to reflect the interactive state. So, if you're hovering over something you can interact with, it should change. |
gkatsev
force-pushed
the
volume-control-volume
branch
from
0f133e9 to
bf4e1f2
Compare
misteroneill
approved these changes
Jan 30, 2017
|
The issue that's failing the build is the sass issue that was just fixed by #4001, so, I'm just going to merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so you don't have to be precise in changing the volume.
One thing I'm not sure is whether I should change the cursor for the entirety of the volume control. I guess I probably should.
I'll be making another PR soon to allow similar functionality on the progress control.