fix width:auto on ie8 & ie9 for remaining-time-display
#3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Jan 26, 2017
|
|
||
| // don't wrap whitespace for the time control and make the text container 0 width | ||
| // fixes a bug with 'width: auto' in IE 8/9 | ||
| .vjs-ie-auto-width-fix { |
There was a problem hiding this comment.
Thinking about this a bit more. Can we re-use the vjs-no-flex class that gets added to the player div? It'll definitely get added in IE8 and 9.
There was a problem hiding this comment.
I will test that
There was a problem hiding this comment.
seems like vjs-no-flex does not fix the width problem
There was a problem hiding this comment.
Sorry, I meant, can we rely on the vjs-no-flex class rather than introducing another one? i.e., move the properties from this selector into that?
11 tasks
gkatsev
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix
width:autoon ie8 & ie9 for remaining-time-displayRequirements Checklist