Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move most volume panel functionality into css state #3981

Merged
merged 15 commits into from
Jan 27, 2017
Merged

move most volume panel functionality into css state #3981

merged 15 commits into from
Jan 27, 2017

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Jan 25, 2017

Description

Built from #3958
Moves as much transition and "logic" into CSS as possible.
Use some javascript to make sure that things are sized properly when tabbing with the keyboard.

@gkatsev gkatsev changed the title Simplify volume move most volume panel functionality into css state Jan 25, 2017
@brandonocasey
Copy link
Contributor

brandonocasey commented Jan 26, 2017 •
edited
Loading

I am not seeing the VolumeControl/VolumeBar being hidden on Firefox/Chorme (there may be others, this is just what I tested on)

@gkatsev
Copy link
Member Author

gkatsev commented Jan 26, 2017

As in if you're just adding the volume control directly? Those are always shown unless when part of the volume panel.

@brandonocasey
Copy link
Contributor

brandonocasey commented Jan 26, 2017 •
edited
Loading

seems like it was a cache issue, I see it working now. Tested with VoiceOver, Chrome, and Firefox. Going to test IE

brandonocasey
brandonocasey reviewed Jan 26, 2017
View reviewed changes
src/js/control-bar/volume-panel.js
this.on(this.muteToggle, 'blur', this.sliderInactive_);
}

sliderActive_() {
Copy link
Contributor

@brandonocasey brandonocasey Jan 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need jsdoc comments or maybe these should just be functions local to the scope above?

@brandonocasey
Copy link
Contributor

brandonocasey commented Jan 26, 2017 •
edited
Loading

I am not seeing the horizontal VolumeControl/VolumeBar hide on IE9 Windows 7(HTML) or IE8 Windows 7 (Flash). This is without any changes to the branch other than having video.js export dom and url so that I can get Flash to work on IE8.

@gkatsev
Copy link
Member Author

gkatsev commented Jan 26, 2017

Horizontal volume control isn't hidden on IE8 and 9. Always expanded.

@brandonocasey
Copy link
Contributor

ah ok well then other than my comment it LGTM

@brandonocasey
Copy link
Contributor

Actually one last thing, I am not seeing the vertical volume bar hide on IE8. Works on IE9

@brandonocasey brandonocasey mentioned this pull request Jan 26, 2017
Closed
11 tasks
@gkatsev
add -ms-filter for vertical panel on ie8.
53b7b0d 
Unfortunately, we lose the ball but potentially will be fixed if we address #3982
@gkatsev gkatsev mentioned this pull request Jan 26, 2017
Merged
@brandonocasey
Copy link
Contributor

@gkatsev tested, the only issue as you said is the missing ball on IE8. I think thats acceptable.

brandonocasey
brandonocasey reviewed Jan 27, 2017
View reviewed changes
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to address the jsdoc comment that I made then this LGTM

@gkatsev gkatsev merged commit 2e2ac6f into master Jan 27, 2017
@gkatsev gkatsev deleted the simplify-volume branch January 27, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkatsev @brandonocasey