Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localise all strings in captions settings #3974

Merged
merged 3 commits into from
Jan 25, 2017
Merged

Localise all strings in captions settings #3974

merged 3 commits into from
Jan 25, 2017

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Jan 24, 2017 •
edited
Loading

Description

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

gkatsev
gkatsev approved these changes Jan 24, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can you rebase and re-update the translations-needed page?

@mister-ben mister-ben force-pushed the localise-captions-settings branch from b13eec5 to c25cf57 Compare January 25, 2017 12:55
@mister-ben
Copy link
Contributor Author

Rebased

@gkatsev gkatsev merged commit 8e7d8cc into videojs:master Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closed Captions Settings not respecting lang file
2 participants
@mister-ben @gkatsev