New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused defaultVolume option default #3915

Merged

gkatsev merged 1 commit into videojs:master from misteroneill:remove-default-volume

Jan 18, 2017

Member

misteroneill commented Jan 4, 2017

There is a default value for a defaultVolume option in the Player. It's never used; so, might as well remove it.

Requirements Checklist

Feature implemented / Bug fixed
Reviewed by Two Core Contributors


          Remove unused defaultVolume option default

misteroneill added the major label

brandonocasey approved these changes

View reviewed changes

brandonocasey added the confirmed label

gkatsev merged commit 5377ffc into videojs:master

misteroneill deleted the remove-default-volume branch

January 19, 2017 20:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed major