Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move vjs hooks test module to separate file #3862

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 15, 2016

No description provided.

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda makes sense to me so that we can reduce the size of the main video.js file. Do you have any other reasons for this?

@gkatsev
Copy link
Member Author

gkatsev commented Dec 15, 2016

Yes. Yesterday when I was trying to add a test to videojs, I added it to the bottom of the file and then went to filter to the "video.js" qunit module and couldn't find my test. It's best to leave each qunit module in a separate file.

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that makes sense, are there any other files that need this change? (if we are going to adopt this)

@gkatsev
Copy link
Member Author

gkatsev commented Dec 15, 2016

According to ack, it's the only one.

@gkatsev gkatsev merged commit 87cd26d into master Dec 15, 2016
@gkatsev gkatsev deleted the vjs-hooks-tests branch December 15, 2016 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants