Deprecate the use of starttime in player.js
#3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
reviewed
Dec 6, 2016
| @@ -1271,12 +1271,14 @@ class Player extends Component { | |||
| * | |||
| * @fires Player#firstplay | |||
| * @listens Tech#firstplay | |||
| * @deprecated In 6.0 passing the `starttime` option to the player will be deprecated | |||
There was a problem hiding this comment.
Rather than "In 6.0" I wonder if we can phrase this as "As of 6.0"?
There was a problem hiding this comment.
seems like a good idea
|
I think this one can be merged in as a minor. |
gkatsev
added
minor
gkatsev
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate the use of
starttimein player.js. It seems like thestartTimeoption is actually used in flash so for the time being that will have to stay. Fixes #3781Requirements Checklist