tests: add Edge to browserstack tests #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forbesjo
reviewed
Dec 5, 2016
| edge_bs: { | ||
| base: 'BrowserStack', | ||
| browser: 'edge', | ||
| browser_version: '14', |
There was a problem hiding this comment.
You might want to leave browser version off so Browserstack can automatically use the latest Edge.
There was a problem hiding this comment.
Makes sense to me. Didn't realize that's how the other evergreens were set up.
|
One comment otherwise LGTM |
misteroneill
approved these changes
Dec 5, 2016
gkatsev
added
confirmed
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Edge as a browser to run tests on in browserstack.