Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bad Apostrophe #3677

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Remove Bad Apostrophe #3677

merged 1 commit into from
Oct 18, 2016

Conversation

curtisgibby
Copy link
Contributor

@curtisgibby curtisgibby commented Oct 10, 2016

Description

A possessive belonging to an "it" doesn't need an apostrophe. Don't believe me? Ask the Oatmeal (look for the velociraptor)!

Specific Changes proposed

Replace incorrect "it's" with correct "its"

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

A possessive belonging to an "it" doesn't need an apostrophe. Don't believe me? Ask [the Oatmeal](http://theoatmeal.com/comics/apostrophe) (look for the velociraptor)!
@mister-ben
Copy link
Contributor

That section is out of date with iOS 10's changes to autoplay. (Good point about the apostrophe though).

@misteroneill
Copy link
Member

We are planning a big documentation sweep in the coming weeks, but if you want to contribute more to that effort @curtisgibby it'd be really appreciated!

This change LGTM, though.

@gkatsev
Copy link
Member

gkatsev commented Oct 18, 2016

I'll pull this in. We can update the actual text later on.

@gkatsev gkatsev merged commit 16c8559 into videojs:master Oct 18, 2016
@curtisgibby curtisgibby deleted the patch-2 branch October 18, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants