Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component's createEl is selectively adding attributes. #2541

Closed
mrwokkel opened this issue Sep 2, 2015 · 1 comment
Closed

Component's createEl is selectively adding attributes. #2541

mrwokkel opened this issue Sep 2, 2015 · 1 comment

Comments

@mrwokkel
Copy link

mrwokkel commented Sep 2, 2015

Component's createEl is selectively adding attributes.
So this:

    this.el_ = videojs.Component.prototype.createEl('iframe', {
      id: this.id_,
      className: 'vjs-tech',
      scrolling: 'no',
      marginWidth: 0,
      marginHeight: 0,
      frameBorder: 0,
      webkitAllowFullScreen: 'true',
      mozallowfullscreen: 'true',
      allowFullScreen: 'true'
    });

Is not creating te last three attributes on the iframe.
Following the code it comes down that in utils/dom.js createEl is using:

el[propName] = val;

instead of:

el.setAttribute(propName, val);
@heff
Copy link
Member

heff commented Sep 2, 2015

We have a similar discussion around this happening in #2176, if you want to join in there and even help us get a fix created.

@heff heff closed this as completed Sep 2, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants