Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make errors more generic. It won't always be "video" #2407

Closed
sirlancelot opened this issue Jul 24, 2015 · 2 comments
Closed

Make errors more generic. It won't always be "video" #2407

sirlancelot opened this issue Jul 24, 2015 · 2 comments

Comments

@sirlancelot
Copy link
Contributor

If an error occurs while trying to play an audio file, I still get the generic "The video could not be loaded, either because the server or network failed or because the format is not supported." error message. Since video.js can play audio files as well, "video" should be changed to "media" or similar.

@mmcc
Copy link
Member

mmcc commented Jul 24, 2015

Ah good point, it's pretty easy to forget about the audio-only use case. Interested in putting a PR together to make the messages more generic?

@gkatsev
Copy link
Member

gkatsev commented Nov 17, 2015

PRed and fixed.

@gkatsev gkatsev closed this as completed Nov 17, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants