Move default options into the constructor #2033
Labels
enhancement
needs: discussion
Needs a broader discussion
pinned
Things that stalebot shouldn't close automatically
Milestone
In #1993 (diff) we discussed moving options into the constructor instead of on the prototype. Secondarily removing the
this.options()
accessor.For the player we use the prototype options as global options for the player, but this could be done by providing a global options object that overrides the default when the player is initialized.
I'm not sure what impact removing the
options()
accessor would have, but right now it creates another source of truth, which isn't great. This would force us to be more specific about providing the info from options that we need.@dmlap @gkatsev, are there places externally where we're relying on the options() getter?
Steps:
component.options()
(v5.0)component.options()
(v.6.0)The text was updated successfully, but these errors were encountered: