Patch to fix IE7

[doublex]

Hello,

I wrote a patch for those who are interessted in supporting IE7:
http://doppelbauer.name/video-js-4.8.1-fix-IE7.patch

Description of the problem:
http://stackoverflow.com/questions/3653444/css-styles-not-applied-on-dynamic-elements-in-internet-explorer-7

Thanks a lot
Markus

[gkatsev]

Can you provide the patch as a PR, would be a lot easier for us to pull in.

[doublex]

*** video.dev.js.orig   2014-09-05 14:58:08.000000000 +0200
--- video.dev.js    2014-09-09 19:38:45.067531992 +0200
*************** vjs.Player.prototype.createEl = function
*** 3517,3523 ****
    // ID will now reference player box, not the video tag
    attrs = vjs.getElementAttributes(tag);
    vjs.obj.each(attrs, function(attr) {
!     el.setAttribute(attr, attrs[attr]);
    });

    // Update tag id/class for use as HTML5 playback tech
--- 3517,3529 ----
    // ID will now reference player box, not the video tag
    attrs = vjs.getElementAttributes(tag);
    vjs.obj.each(attrs, function(attr) {
!     // workaround IE7: http://stackoverflow.com/questions/3653444/css-styles-not-applied-on-dynamic-elements-in-internet-explorer-7
!     if (attr == 'class') {
!       el.className = attrs[attr];
!     }
!     else {
!       el.setAttribute(attr, attrs[attr]);
!     }
    });

    // Update tag id/class for use as HTML5 playback tech

[t2y]

See this comment on #1466. It works for me. Thank you again!

[doublex]

@gkatsev
Sorry - git is not the right tool for me.
Is there a chance, that this patch will be applied to video.js?

[t2y]

@gkatsev Could you merge this patch? It works for me.

[mmcc]

@doublex We'll merge the patch, it would just be really nice to get these kinds of things as PRs rather than just comments of diffs. Not to sound unappreciative (we really are!), it would just be great to learn how we can help get past the Git barrier since you've actually submitted a few great fixes now.

This will most likely get pulled in / released tomorrow afternoon.

[doublex]

@mmcc
Thanks a lot for your kind help - and sorry for my ignorance.

[mmcc]

No worries at all! Again, we're interested in learning how we can help you get these kinds of things submitted without you having to touch Git. We have a project we've been working on to try and smooth the submission process, but it's not quite ready for consumption yet. If it's cool with you, we might ping you for feedback here pretty soon.

Just out of curiosity, @doublex, what's your development environment?

[mmcc]

I went ahead and created a PR for this: #1542

[t2y]

Thank you for merging!

[heff]

Closed by #1542