Deprecate method names before removing them

[dmlap]

In 4.6.0, requestFullScreen() was renamed to requestFullscreen(). According to semver, removal of the old form probably should have waiting until version 5.0. In the future, I propose that we keep the old method name, log a warning about deprecation, and delegate to the "modernized" equivalent.

[heff]

That was the intention (per the docs) but apparently it wasn't handled correctly in code.

Is that enough to close this issue, or do you want to see that implemented for requestFullscreen? I'm fine either way.

[dmlap]

I missed the docs and thought the removal was intentional. I'm not sure why but it looks like requestFullScreen() is another victim of aggressive minification: http://jsbin.com/lalahaliyoda/1/edit. I see it in the externs though. Any idea what happened here?

[heff]

@dmlap so the issue was the difference between exports and externs. Externs don't guarantee the function will exist in the final compile. Closure may still decide to remove the function if it doesn't look like it's being used internally anywhere.

[dmlap]

Ugh. Ok, I'll keep that in mind for the future, thanks.