-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the classname vjs-control to vjs-button #1204
Comments
If you wanted to get this into a 4.x release, duplicate the names, otherwise, this is a pretty straightforward transition in a breaking API change release. |
We're going to break all the things when 5.0 drops. |
We discussed this a little on Friday, and the conclusion was that we need to switch to use the |
Decided to add vjs-button instead of removing vjs-control |
Working on this. |
Closed by #2084! |
Originally 'control' was going to be the parent class of buttons and all other controls, but in practice only buttons use vjs-control. It would be a lot cleaner if we just vjs-button for button elements.
This would break existing skins so should wait for a major release. Though it's possible we could duplicate classes to help in the transition.
The text was updated successfully, but these errors were encountered: