Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the classname vjs-control to vjs-button #1204

Closed
heff opened this issue May 14, 2014 · 6 comments
Closed

Change the classname vjs-control to vjs-button #1204

heff opened this issue May 14, 2014 · 6 comments

Comments

@heff
Copy link
Member

heff commented May 14, 2014

Originally 'control' was going to be the parent class of buttons and all other controls, but in practice only buttons use vjs-control. It would be a lot cleaner if we just vjs-button for button elements.

This would break existing skins so should wait for a major release. Though it's possible we could duplicate classes to help in the transition.

@heff heff added this to the v5.0.0 milestone May 14, 2014
@gkatsev
Copy link
Member

gkatsev commented May 14, 2014

If you wanted to get this into a 4.x release, duplicate the names, otherwise, this is a pretty straightforward transition in a breaking API change release.

@mmcc
Copy link
Member

mmcc commented May 20, 2014

We're going to break all the things when 5.0 drops. :trollface:

@heff
Copy link
Member Author

heff commented Apr 26, 2015

We discussed this a little on Friday, and the conclusion was that we need to switch to use the <button> element first, then decide what makes sense here classname wise. I think we should still have a vis-button class, and then decide if the vjs-control class is still necessary. It would be nice if the CSS class names matched the class inheritance.

@dmlap
Copy link
Member

dmlap commented Apr 27, 2015

Decided to add vjs-button instead of removing vjs-control

@forbesjo
Copy link
Contributor

Working on this.

@heff
Copy link
Member Author

heff commented Apr 29, 2015

Closed by #2084!

@heff heff closed this as completed Apr 29, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants