Skip to content

Commit

Permalink
feat: add class to normalise time control display (#8833)
Browse files Browse the repository at this point in the history
## Description
Time controls continue to cause confusion as they are included by
default but hidden by default. e.g. #8534 Adding CSS to display them is
not intuitive.

## Specific Changes proposed
Changing the default styles would be problematic before a major version.
This PR proposes adding an optional `vjs-normalise-time-controls` class
a user can add to the player, as an opt in.

This will default all time controls to being shown, except when live
content is playing. Users would then have to remove the time controls in
player options, or with `hide()` or `dispose()`.

## Requirements Checklist
- [ ] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [x] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [ ] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [ ] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors

Co-authored-by: Adam Waldron <[email protected]>
  • Loading branch information
mister-ben and adrums86 authored Sep 9, 2024
1 parent 8c56e31 commit 5e6b536
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/css/components/_time.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,7 @@
display: none;
line-height: 3em;
}

.vjs-normalise-time-controls:not(.vjs-live) .vjs-time-control {
display: flex;
}

0 comments on commit 5e6b536

Please sign in to comment.