Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: ensure transient button event listeners are removed on dispose (#…
…8796) ## Description Transient button sets an event listener on the player directly instead of on itself, which doesn't get cleaned up when disposed. Fixes #8795 ## Specific Changes proposed Call `on` on the component with player as the first arg, instead of calling `on` on the player directly. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
- Loading branch information