feat: ll-hls warnings and info #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brandonocasey
commented
Jan 20, 2021
•
brandonocasey
commented
- Adds warning/info logs for all ll-hls tags
- Adds defaults for ll-hls tags
brandonocasey
commented
Jan 20, 2021
| // we need this helper because defaults are based upon targetDuration and | ||
| // partTargetDuration being set, but they may not be if SERVER-CONTROL appears before | ||
| // target durations are set. | ||
| const setHoldBack = function(manifest) { |
There was a problem hiding this comment.
Had to break this into it's own function see the comment above this function.
brandonocasey
commented
Jan 20, 2021
brandonocasey
commented
Jan 20, 2021
test/fixtures/m3u8/llhlsDelta.json
Outdated
| @@ -172,7 +173,7 @@ | |||
| "CAN-BLOCK-RELOAD": true, | |||
| "CAN-SKIP-UNTIL": 12, | |||
| "PART-HOLD-BACK": 1, | |||
| "HOLD-BACK": 2 | |||
| "HOLD-BACK": 12 | |||
There was a problem hiding this comment.
targetDuration is 4 for this source, which means HOLD-BACK has to be at least 12.
brandonocasey
force-pushed
the
feat/llhls-warnings
branch
from
1990190 to
e21afd7
Compare
gkatsev
reviewed
Jan 21, 2021
| this.parser.end(); | ||
|
|
||
| const warnings = [ | ||
| 'ignoring invalid target duration: undefined' |
There was a problem hiding this comment.
this has undefined because we tried to parse foo as an int which failed, and we just didn't set a value in that case?
If we would want to fix this, we'd want to do it in a separate PR.
There was a problem hiding this comment.
I think I will be fixing up some of the old warnings and info logs to better represent what we are doing now in another pull request.
brandonocasey
force-pushed
the
feat/llhls-warnings
branch
from
938cb5a to
a4565ce
Compare
gkatsev
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.