fix: ArrayBuffer.isView may not be available everywhere #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
previously approved these changes
Mar 21, 2022
|
Yup, this needs vhs-utils and also probably need to update aes-decrypted, m3u8-parser, and mpd-parser to make sure that all the vhs-utils deps are on the same version. I'll get to it some time this week, if not today. |
Codecov Report
@@ Coverage Diff @@
## main #1258 +/- ##
==========================================
- Coverage 86.39% 86.30% -0.10%
==========================================
Files 39 39
Lines 9817 9840 +23
Branches 2283 2292 +9
==========================================
+ Hits 8481 8492 +11
- Misses 1336 1348 +12
Continue to review full report at Codecov.
|
misteroneill
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on videojs/vhs-utils#33
Fixes #1134