From f7eb9ce1cedc65a6c5d2f180122c7965cfbdb351 Mon Sep 17 00:00:00 2001 From: brandonocasey Date: Thu, 8 Apr 2021 13:20:17 -0400 Subject: [PATCH 1/3] chore: uninstall chromimum browser on ubuntu --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e58d43019..359ed2606 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,6 +56,10 @@ jobs: run: sudo apt-get install ffmpeg pulseaudio if: ${{startsWith(matrix.os, 'ubuntu')}} + - name: remove chromium + run: sudo apt-get remove chromium-browser + if: ${{startsWith(matrix.os, 'ubuntu')}} + - name: start pulseaudio for firefox on linux w/o browserstack run: pulseaudio -D if: ${{startsWith(matrix.os, 'ubuntu')}} From e140442739ed1eb9b46d23b0d02efb44b228250d Mon Sep 17 00:00:00 2001 From: brandonocasey Date: Thu, 8 Apr 2021 13:24:19 -0400 Subject: [PATCH 2/3] try chromium*, update to ubuntu latest --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 359ed2606..7cb1ce1c6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,7 +5,7 @@ on: [push, pull_request] jobs: should-skip: continue-on-error: true - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest # Map a step output to a job output outputs: should-skip-job: ${{steps.skip-check.outputs.should_skip}} @@ -21,7 +21,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-18.04] + os: [ubuntu-latest] test-type: [unit, playback, playback-min, coverage] env: BROWSER_STACK_USERNAME: ${{secrets.BROWSER_STACK_USERNAME}} @@ -57,7 +57,7 @@ jobs: if: ${{startsWith(matrix.os, 'ubuntu')}} - name: remove chromium - run: sudo apt-get remove chromium-browser + run: sudo apt-get remove chromium* if: ${{startsWith(matrix.os, 'ubuntu')}} - name: start pulseaudio for firefox on linux w/o browserstack From d20b6eb6cbb98a2ec2a2947c89d7e2d40978373b Mon Sep 17 00:00:00 2001 From: brandonocasey Date: Thu, 8 Apr 2021 13:28:15 -0400 Subject: [PATCH 3/3] skip chromium in karma --- .github/workflows/ci.yml | 4 ---- scripts/karma.conf.js | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7cb1ce1c6..91a1b786a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,10 +56,6 @@ jobs: run: sudo apt-get install ffmpeg pulseaudio if: ${{startsWith(matrix.os, 'ubuntu')}} - - name: remove chromium - run: sudo apt-get remove chromium* - if: ${{startsWith(matrix.os, 'ubuntu')}} - - name: start pulseaudio for firefox on linux w/o browserstack run: pulseaudio -D if: ${{startsWith(matrix.os, 'ubuntu')}} diff --git a/scripts/karma.conf.js b/scripts/karma.conf.js index 3e7adefbc..5c7d21291 100644 --- a/scripts/karma.conf.js +++ b/scripts/karma.conf.js @@ -10,7 +10,7 @@ module.exports = function(config) { preferHeadless: false, browsers(aboutToRun) { return aboutToRun.filter(function(launcherName) { - return !(/^Safari/).test(launcherName); + return !(/^(Safari|Chromium)/).test(launcherName); }); }, files(defaults) {