fix: filter out unsupported subtitles for dash #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Sep 29, 2020
gkatsev
reviewed
Sep 29, 2020
|
I reworked this pull request to work for dash/hls using more standard functions in master-playlist-controller. This pull request now depends upon: videojs/vhs-utils#19 |
|
I think this needs to be rebased |
brandonocasey
force-pushed
the
fix/unsupported-subs
branch
from
4a0a009 to
d8eadfc
Compare
|
Looks like this needs an update to mpd-parser? |
gkatsev
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the newest version of mpd-parser
0.13.0we added support for exposing subtitle codecs so that we could filter out any that we do not support. For now I have it filtering out all subtitles that have codecs, but we may want to exclude only known codecs. This behavior can be seen withTears of Steal - Widevine (Unified Streaming)as the subs there arestpp.ttml.im1tDepends upon updates in:
mpd-parser@videojs/vhs-utils