Chore: rename mediaConfig_ and startingMedia_ #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Sep 21, 2020
brandonocasey
force-pushed
the
fix/buffered-between-media
branch
from
d3924da to
9dac6f3
Compare
brandonocasey
force-pushed
the
chore/rename-media-config
branch
from
7cb6b24 to
f84aa36
Compare
brandonocasey
force-pushed
the
chore/rename-media-config
branch
from
f84aa36 to
3068957
Compare
gkatsev
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mediaConfig_ and startingMedia_ are fairly poor names for variables, we should do better and rename them to something that can be easily understood. This pull request aims to do that. Originally this work would have been done as a part of #950 but this change might have a bigger impact than intended.