fix: audio groups with the same uri as media do not count #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Sep 17, 2020
gesinger
approved these changes
Sep 17, 2020
gkatsev
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When An audio group has the same uri as a main playlist, don't count it as an audio group.
The code that I am using is from this commit
I removed this code early on the the VHS 2 process as it was causing other issues, but after digging up some demuxed live streams I no longer see issues with live stream timeouts.
I created a source that replicates this issue and uploaded it next to some of our other test content. I also tested with a few of the demuxed live streams that we have and they all appear to work. It is likely that the live stream startup issues that I was seeing were fixed somewhere else.