fix: do not use remove source buffer on ie 11 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Jul 13, 2020
gesinger
reviewed
Jul 13, 2020
Co-authored-by: Garrett Singer <[email protected]>
gesinger
previously approved these changes
Jul 13, 2020
brandonocasey
force-pushed
the
fix/no-remove-source-buffer-ie11
branch
from
bb43f6b to
ca59b3b
Compare
gesinger
reviewed
Jul 14, 2020
| @@ -833,7 +807,8 @@ QUnit.module('SegmentLoader', function(hooks) { | |||
| done(); | |||
There was a problem hiding this comment.
It won't let me write on the other line, but may be worth updating the test message above.
gesinger
approved these changes
Jul 14, 2020
gkatsev
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like ie 11 likes to error when using removeSourceBuffer, let's just say that it isn't supported and not use it.