Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS Playback Stops With 'pts' Error #798

Closed
mikeswanson opened this issue Apr 3, 2020 · 4 comments
Closed

HLS Playback Stops With 'pts' Error #798

mikeswanson opened this issue Apr 3, 2020 · 4 comments

Comments

@mikeswanson
Copy link

Description

When playing back some HLS-encoded media, video.js shows a buffering spinner and will not continue playback. The underlying problem has been fixed in recent versions of the mux.js library.

Sources

The issue can be seen in this single variant HLS stream around the 34-second mark: https://app.voodle.dev/assets/2ba91016-4810-4de8-884d-ab1990709fe4/playlist.m3u8

Steps to reproduce

Here is a simple page that uses video.js to playback a problematic HLS stream. The problem happens around 34 seconds into the video: https://app.voodle.dev/assets/2ba91016-4810-4de8-884d-ab1990709fe4/index.html

Results

Expected

I expect the video to continue playback. A version with the latest mux.js does not have this issue.

Error output

Uncaught TypeError: Cannot read property 'pts' of undefined
    at findSeiNals (video.js:35979)
    at video.js:36084
    at Array.forEach (<anonymous>)
    at parseCaptionNals (video.js:36068)
    at parseEmbeddedCaptions (video.js:36120)
    at CaptionParser.parse (video.js:36222)
    at video.js:49019
    at Object.callback (video.js:39502)
    at cbOnce (video.js:8532)
    at XMLHttpRequest.loadFunc (video.js:8606)

Additional Information

This issue has been fixed in later versions of mux.js. Specifically: https://github.com/videojs/mux.js/blob/48bfe005139aac25618453e9b3f5203f3895b1a5/lib/mp4/caption-parser.js#L88-L101

videojs-http-streaming version

what version of videojs-http-streaming does this occur with?
videojs-http-streaming 1.13.2

videojs version

what version of videojs does this occur with?
video.js 7.6.6

Browsers

At least Chrome 80.0.3987.163

Platforms

what platforms are affected? please include operating system and version or device and version for each

  • At least macOS Catalina (10.15.4)

Other Plugins

None

Other JavaScript

None

@welcome
Copy link

welcome bot commented Apr 3, 2020

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented Apr 8, 2020

Looks like this should be fixed in master but we'll also make sure to update mux.js in the 1.x branch and get a release out soon.

@jessica-pixvana
Copy link

@gkatsev how do i track when this fix makes it into master of video.js?

@gkatsev
Copy link
Member

gkatsev commented Apr 22, 2020

1.13.3 was just released with this change, you can include it manually, otherwise, you can wait till next release of Video.js.

@gkatsev gkatsev closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants