Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Use middleware and a wrapped function for seeking instead of relying on unreliable 'seeking' events (#161)" #777

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Mar 18, 2020

This reverts commit 6c68761.

This helps address #378 and videojs/video.js#6444.

…d of relying on unreliable 'seeking' events (#161)"

This reverts commit 6c68761.
// Whenever we seek internally, we should update both the tech and call our own
// setCurrentTime function. This is needed because "seeking" events aren't always
// reliable. External seeks (via the player object) are handled via middleware.
// Whenever we seek internally, we should update the tech
this.options_.seekTo = (time) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is seekTo still used anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's currently used inside of seekToProgramTime and related functions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we then just leave all of the other uses of seekTo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, we specifically need seekTo for seekToProgramTime because STPT doesn't have access to anything else like the tech or what not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth keeping it consistent then. Also hides the use of tech a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants