feat: Utilize option to override native on tech #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forbesjo
reviewed
Apr 9, 2018
src/videojs-http-streaming.js
Outdated
| (tech.featuresNativeVideoTracks || tech.featuresNativeAudioTracks)) { | ||
| throw new Error('Overriding native HLS requires emulated tracks. ' + | ||
| 'See https://git.io/vMpjB'); | ||
| if (this.options_.overrideNative) { |
There was a problem hiding this comment.
We'll need to fall back to the old behavior if the APIs aren't available (older video.js 6)
|
This feature is now in video.js 7.0.0-rc.1, this PR can either bump up the video.js version to pass the tests or we can mock that functionality and test both with and without that API. I think we should do the latter since this PR has backwards compatible changes. |
added 2 commits
May 24, 2018 17:24
|
#102 has been merged so this PR does not need to update the package files |
chore: update tests and pages for video.js 7 (#102)
forbesjo
approved these changes
Jun 6, 2018
forbesjo
changed the title
|
Needs README updates https://github.com/videojs/http-streaming#overridenative |
|
I think the REAME code snippet should show how to set it up with both the player constructor options and the video source options |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilize the addition of
overrideNativeAudioTracksandoverrideNativeVideoTracksas added in videojs/video.js#5074.I'm in the process of adding tests, but would like eyes on this and the above noted PR before getting too far along.
Specific Changes proposed
This PR removes the need to set
nativeAudioTracksandnativeVideoTracksto false when enabling overrideNative.Requirements Checklist