Don't try to initialize media keys in IE11 #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
Nov 12, 2019
gkatsev
approved these changes
Nov 12, 2019
brandonocasey
added a commit
that referenced
this pull request
Jan 9, 2020
brandonocasey
added a commit
that referenced
this pull request
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PlayReady media key setup (done via
msSetMediaKeys()in IE11) is a side effect of the on-demandplayer.eme.initializeMediaKeys()call and fails because the videoreadyStateis still 0 at that point. FormsSetMediaKeys()to work thereadyStateapparently has to be > 0. Therefore, we need to bypassinitializeMediaKeys()in IE11 and delay themsSetMediaKeys()call until the video element is ready.Specific Changes proposed
Add a
!(videojs.browser.IE_VERSION === 11)condition before callinginitializeMediaKeys(), so that we fall back to the old contrib-eme key setup behavior that waits until themsneedkeyevent in IE 11, and continue to use the on-demand key setup behavior everywhere else.