fix(id3): ignore unsupported id3 frames #437
Conversation
When we get an unsupported id3 frame, we don't parse its time. This ends up coming back to us as NaN in the timing for the frame. Instead of trying to create a cue for this frame, ignore it whenever the time isn't a number or when it isn't finite. Fixes videojs/video.js#5823
|
I would be happy to test it using our media. I will get back to you before the weekend, as a little overloaded with workload at the moment. If it does not fix it, I will make example media available for your testing. |
|
@RafalLukawiecki that would be awesome! |
|
Pleasure. I just realised that the PR is on the http-streaming component only. Can I get the PR easily applied using a patch to the npm-installed most recent version of video.js or do I need to create a new testing environment for this PR? |
|
@RafalLukawiecki you can test on here https://deploy-preview-437--videojs-http-streaming.netlify.com/ |
|
Thank you, I understand now. In that case it will still require me to make one of our video streams public, so that I can play against your hosted test. Will do. |
|
since it loads from your browser, as long as you can reach the resource you should be able to test without making it public to the web at large |
|
I have tested using your very helpful hosted tester. I am very happy to say that this PR fixes the bug that we have encountered. Many thanks! When will it appear in a version of video.js that we can install using npm? Otherwise we have to build from source, right? |
|
@RafalLukawiecki glad to hear it! If we can test it on our end, it may be out this week, otherwise maybe within a couple of weeks. |
|
@gkatsev Would it help if I made a video stream available publicly that showed the original issue and which works now? I can have that ready tomorrow. |
When we get an unsupported id3 frame, we don't parse its time. This ends
up coming back to us as NaN in the timing for the frame. Instead of
trying to create a cue for this frame, ignore it whenever the time isn't
a number or when it isn't finite.
Fixes videojs/video.js#5823