Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose custom segment property in the segment metadata track #429

Merged
merged 1 commit into from
Mar 14, 2019
Merged

fix: expose custom segment property in the segment metadata track #429

merged 1 commit into from
Mar 14, 2019

Conversation

forbesjo
Copy link
Contributor

@forbesjo forbesjo commented Mar 14, 2019 •
edited
Loading

Description

Exposes the missing custom segment property in the segment metadata track, this property is present on the segment object parsed by VHS.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@forbesjo forbesjo force-pushed the custom-segment-metadata branch from dfa09df to 91b6aa7 Compare March 14, 2019 21:04
@forbesjo forbesjo merged commit 17510da into master Mar 14, 2019
@forbesjo forbesjo deleted the custom-segment-metadata branch March 14, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gesinger gesinger gesinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forbesjo @gesinger