fix: Prevent infinite buffering at the start of looped video on edge #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now Edge will sometimes buffer indefinitely once a video that is set to loop moves back to
currentTime
0.After investigating this it appears that Edge does not set
tech.seeking()
totrue
during aseeking
event for looping back tocurrentTime
0. Normalseeking
events do settech.seeking()
to true, as expected.Solution
I don't think that we need the extra check for
seeking
on thetech
at the start of the if statement. If we just had aseeking
event it should be fairly evident that we are seeking. I also think that the other two checks (for currentTime, and loop) should be enough to have this only happen when a video is looping.