fix: ensure content loops #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
forbesjo
previously approved these changes
Oct 15, 2018
gesinger
reviewed
Oct 15, 2018
| @@ -320,6 +320,13 @@ class HlsHandler extends Component { | |||
| this.masterPlaylistController_.smoothQualityChange_(); | |||
| } | |||
| }); | |||
|
|
|||
| this.on(this.tech_, 'seeking', function() { | |||
There was a problem hiding this comment.
It may be worth us adding a comment essentially saying that the middleware can't catch looping behavior because the tech fires a seeking event and we don't get that through the middleware, thus we listen for that specific case.
test/playback.test.js
Outdated
| type: 'application/x-mpegURL' | ||
| }); | ||
| player.one('playing', function() { | ||
| player.vhs.mediaSource.on('sourceopen', () => { |
There was a problem hiding this comment.
Is it possible for the playing event to fire before the media source is opened? If so, it may be best for us to add one more listener (for ended), then check for sourceopen after that.
gesinger
approved these changes
Oct 15, 2018
forbesjo
approved these changes
Oct 15, 2018
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #231, playback stalls if looping
Specific Changes proposed
On a seek to 0 when loop enabled, call
setCurrentTime(0)on vhs.Requirements Checklist