Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast quality change does not eject audio buffer when using multi-lingual stream #255

Open
squarebracket opened this issue Oct 11, 2018 · 2 comments
Labels

Comments

@squarebracket
Copy link
Contributor

squarebracket commented Oct 11, 2018

Description

The changes introduced by #113 seems to not eject the audio buffer when streaming a feed with multiple audio languages. I checked with both a multi-lingual live feed and VOD feed.

Sources

I don't have one I can post freely, but I have one available upon request.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Play a multi-lingual feed
  2. Switch audio rate via representations API
  3. Wait to hear the audio quality change

Results

Expected

Audio buffer is ejected

Additional Information

videojs-http-streaming version

videojs-http-streaming 1.3.0

videojs version

video.js 6.10.3

Other Plugins

I've got a custom-written quality level switcher plugin which simply uses the representations API.

Tangential Thought

Maybe the default switch method for live feeds should be smooth switching?

@welcome
Copy link

welcome bot commented Oct 11, 2018

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@forbesjo forbesjo added the bug label Oct 24, 2018
@gesinger
Copy link
Contributor

This may be an old one, but @squarebracket , do you still happen to have a source for this? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants