Clamp seekable end #1433
Merged
Clamp seekable end #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2023 13:16
Codecov Report
@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 85.98% 85.99%
=======================================
Files 42 42
Lines 10428 10430 +2
Branches 2412 2413 +1
=======================================
+ Hits 8967 8969 +2
Misses 1461 1461
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
misteroneill
approved these changes
Oct 11, 2023
alex-barstow
approved these changes
Oct 11, 2023
wseymour15
approved these changes
Oct 11, 2023
This was referenced Oct 30, 2023
dzianis-dashkevich
added a commit
that referenced
this pull request
Nov 30, 2023
* fix seekable end * fix eslint error --------- Co-authored-by: Dzianis Dashkevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have default
liveEdgePaddingas 3 * targetDuration.Assume we have a stream with a maximum of three segments.
Each segment's actual duration is less than a
targetDuration.In this scenario, we may have a
seekable.endless than aseekable.start.This may lead to unexpected behavior.
Specific Changes proposed
Clamp
seekable.endto make sure that it is more or equal toseekable start.Requirements Checklist