fix: update m3u8 parser version and restore dateTimeObject and dateTimeString usage #1412
Conversation
| @@ -421,7 +421,7 @@ export default class PlaylistLoader extends EventTarget { | |||
| this.dateRangesStorage_.setPendingDateRanges(mediaPlaylist.dateRanges); | |||
| const availableDateRanges = this.dateRangesStorage_.getDateRangesToProcess(); | |||
|
|
|||
| if (!availableDateRanges.length) { | |||
| if (!availableDateRanges.length || !this.addDateRangesToTextTrack_) { | |||
There was a problem hiding this comment.
Noticed that there were several !this.addDateRangesToTextTrack_ is not a function errors when I tested dateRanges with a specific stream. On logging !!his.addDateRangesToTextTrack_, noticed that the function was undefined on every alternate loadedplaylist event (line 410). Not sure why this is happening, so added a quick fix here before debugging in detail.
There was a problem hiding this comment.
This seems to be because the test stream has subtitles, which in this case we create a PlaylistLoader for, this does not have the addDateRangesToTextTrack_ function defined, as it is only needed for the mainPlaylistLoader for HLS.
Codecov Report
@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 85.56% 85.55% -0.01%
==========================================
Files 41 41
Lines 10147 10145 -2
Branches 2353 2351 -2
==========================================
- Hits 8682 8680 -2
Misses 1465 1465
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
harisha-swaminathan
changed the title
This PR shouldn't be merged before
Description
Restores dateTimeObject and dateTimeString segment properties that were previously removed and refactored in these two PRs